ci: only cache Rust builds on the main branch #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other branches This should avoid hitting the GitHub 10GB cache limit
|
Boshen
changed the title
github-actions
bot
added
the
team
Boshen
changed the title
IWANABETHATGUY
approved these changes
Apr 18, 2023
hyf0
approved these changes
Apr 18, 2023
siyou
pushed a commit
to siyou/rspack
that referenced
this pull request
May 14, 2023
ci: only cache Rust builds on the main branch, and only read cache on other branches This should avoid hitting the GitHub 10GB cache limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid hitting the GitHub 10GB cache limit
This is bad:
we quickly run out of cache because some of the PRs are saving the cache.
Related issue (if exists)
Summary
🤖 Generated by Copilot at 8705c96
This pull request adds conditions to the
save-cachesteps of thecheck-rsandreusable-buildworkflows in.github/workflows. The conditions prevent the Rust build cache from being overwritten by non-main branches, which could cause issues for the CI/CD pipeline.Walkthrough
🤖 Generated by Copilot at 8705c96
mainbranch (link, link)